Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some wrong words among in the code #14189

Closed
wants to merge 3 commits into from

Conversation

DanialZhouMAX
Copy link

unmarshaling -> unmarshalling

@CLAassistant
Copy link

CLAassistant commented Jul 6, 2024

CLA assistant check
All committers have signed the CLA.

terencechain
terencechain previously approved these changes Jul 14, 2024
@james-prysm
Copy link
Contributor

Test_customUint_UnmarshalJSON is breaking

@DanialZhouMAX
Copy link
Author

Test_customUint_UnmarshalJSON is breaking

https://github.com/kubernetes-sigs/yaml/blob/v1.2.0/yaml.go#L60 is the reason

Due to this repo is not update since a long time ago, I will revert the test code to adapt the dependence

@rkapka
Copy link
Contributor

rkapka commented Jul 31, 2024

marshaling is the US spelling of the word

@rkapka rkapka closed this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants